@claude This would cause a N+1 in the admin page. I think we use Django's annotate to fetch if the invitation letter exists or not in the django admin query instead of this method

Claude finished @marcoacierno's task —— View job

N+1 Query Issue Fixed ✅

You're absolutely right about the N+1 issue! I've optimized the implementation using Django's Exists() annotation.

Todo List:

• Read repository guidelines (CLAUDE.md)
• Examine current implementation
• Find invitation letter model relationship
• Implement queryset annotation in GrantAdmin
• Update/remove the model method
• Test the optimization
• Commit and push changes

Changes Made:

1. Added annotation to GrantAdmin.get_queryset():

   • Uses Exists() with InvitationLetterRequest.objects.filter() to check for invitation letter requests
   • This performs a single SQL query with an EXISTS subquery instead of N individual queries

2. Updated has_invitation_letter_request_flag() method:

   • Now uses getattr(obj, 'has_invitation_letter_request', False) to access the annotated field
   • No longer calls the model method that would trigger individual queries

3. Removed the has_invitation_letter_request() method from Grant model:

   • This method is no longer needed since we're using annotation
   • Eliminates the source of the N+1 queries

Performance Impact:

• Before: 1 query to load grants + N queries for invitation letter checks = N+1 queries
• After: 1 query with EXISTS subquery = 1 query total

The optimization follows the same pattern already used for is_proposed_speaker, is_confirmed_speaker, and has_voucher annotations in the same admin class.